Network Programming in Elixir and Erlang:Designing a Simple Chat Protocol broadcast message (page 39)

Pragmatic Bookshelf PragProg Customers
,
1

The paragraph says:

When a client sends a broadcast message to the server,
from_username must be an empty string. When the server sends a broadcast
message to clients, from_username will be the username of the sender of the
broadcast message, or an empty string if the broadcast message comes from
the server itself.

However, in my opinion, when a client sends a broadcast message to the server, from_username should be the client’s actual username—not an empty string.

2

You have the client’s username already in the connection’s state. I added this to the para:

When a client sends a broadcast message to the server, `from_username` must be an empty string---the connection is already storing the client's username, so including it would be redundant.

Thank you!