When you are under pressure to deliver you ideally want your Pull Request to be reviewed, approved and merged as quick as possible. So does everyone else! I’ve seen a Pull Request go through a review for over 52 days! An extreme example, and most of the debate was petty.
But where do you draw the line? Does the wrong variable name stop you from approving someone’s work? Or, would you ask for a complete redesign of a submitted solution?
I would like to open a discussion around the Pull Request and share our experiences and practices.
Here’s some questions that I have pondered many a time:
- How do you review Pull Requests ?
- When do you review Pull Requests ?
- How long are you willing to wait for a review / approval?
- How long do you spend reviewing a Pull Request?
- How many Pull Requests would you review in a day ?
- What is the best size (number of modifications/ additions) for a Pull Request ?
- How frequently do you submit Pull Requests? (daily / weekly / monthly)?
- How do you feel emotionally when someone suggests changes?
- How do you feel emotionally when you suggest changes?